Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop remaining jobs, update migration report doc, enforce not adding any new default cluster jobs #33272

Merged
merged 11 commits into from
Aug 8, 2024
Merged

Drop remaining jobs, update migration report doc, enforce not adding any new default cluster jobs #33272

merged 11 commits into from
Aug 8, 2024

Conversation

BenTheElder
Copy link
Member

I will be scaling the old build cluster behind cluster: default down to zero nodes shortly, then we can look at dropping it from prow's KUBECONFIGs.

This fixes #33226

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Aug 8, 2024
@k8s-ci-robot k8s-ci-robot requested a review from adelina-t August 8, 2024 20:14
@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2024
@k8s-ci-robot k8s-ci-robot requested a review from andyzhangx August 8, 2024 20:14
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Aug 8, 2024
@dims
Copy link
Member

dims commented Aug 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2024
BenTheElder
BenTheElder commented Aug 8, 2024
View reviewed changes
config/tests/jobs/jobs_test.go
"capz-azure-file-vmss-master",
"capz-conformance-dual-stack-master",
"capz-conformance-ipv6-master",
"capz-conformance-master",
"ci-test-infra-gencred-refresh-kubeconfig",
"ci-test-infra-rotate-legacy-default-build-sa-json-key",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to drop this one next, but I want to have the cluster actually not running jobs first and then confirm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

talked to cole about this, we can clean it up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#33274

upodroid
upodroid approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,upodroid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder BenTheElder mentioned this pull request Aug 8, 2024
Closed
@k8s-ci-robot k8s-ci-robot added area/testgrid and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 8, 2024
@BenTheElder BenTheElder force-pushed the drop-remaining-jobs branch from a7eaeb0 to f31d37d Compare August 8, 2024 20:37
@BenTheElder
Copy link
Member Author

fixed yamllint: no EOL at end of file in two files, testgrid config referencing generated dashboards that are now emtpy

@ameukam
Copy link
Member

ameukam commented Aug 8, 2024

/lgtm

/pony

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

@ameukam: pony image

In response to this:

/lgtm

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 6bca3ee into kubernetes:master Aug 8, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key csi-driver-smb-config.yaml using file config/jobs/kubernetes-csi/csi-driver-smb/csi-driver-smb-config.yaml
  • key azuredisk-csi-driver-config.yaml using file config/jobs/kubernetes-sigs/azuredisk-csi-driver/azuredisk-csi-driver-config.yaml
  • key azuredisk-csi-driver-v2-config.yaml using file config/jobs/kubernetes-sigs/azuredisk-csi-driver/azuredisk-csi-driver-v2-config.yaml
  • key azurefile-csi-driver-config.yaml using file config/jobs/kubernetes-sigs/azurefile-csi-driver/azurefile-csi-driver-config.yaml
  • key blob-csi-driver-config.yaml using file config/jobs/kubernetes-sigs/blob-csi-driver/blob-csi-driver-config.yaml
  • key windows-unit-presubmits.yaml using file ``
  • key release-1.26.yaml using file ``
  • key release-1.27.yaml using file ``
  • key release-1.28.yaml using file ``
  • key release-master.yaml using file ``

In response to this:

I will be scaling the old build cluster behind cluster: default down to zero nodes shortly, then we can look at dropping it from prow's KUBECONFIGs.

This fixes #33226

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the drop-remaining-jobs branch August 8, 2024 22:34
@BenTheElder BenTheElder mentioned this pull request Aug 8, 2024
Merged
@michelle192837 michelle192837 mentioned this pull request Aug 21, 2024
Closed
44 tasks
@andyzhangx andyzhangx mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@adelina-t adelina-t Awaiting requested review from adelina-t

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees

@dims dims

@ameukam ameukam

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

removing unmigrated CI jobs ahead of prow control-plane migration
5 participants
@BenTheElder @dims @k8s-ci-robot @ameukam @upodroid